Apache MyFaces
MyFaces Orchestra
MyFaces Orchestra - Modules
Foundation

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.0

Threshold is Low

Effort is Default

Summary

Classes Bugs Errors Missing Classes
885 135 0 1

Files

Class Bugs
org.apache.myfaces.orchestra.conversation.ConversationManager 4
org.apache.myfaces.orchestra.conversation.ConversationRequestParameterProvider 2
org.apache.myfaces.orchestra.conversation.CurrentConversationAdvice 1
org.apache.myfaces.orchestra.conversation.CurrentConversationInfo 1
org.apache.myfaces.orchestra.conversation.jsf.AccessScopePhaseListener 1
org.apache.myfaces.orchestra.conversation.spring.AbstractSpringOrchestraScope 1
org.apache.myfaces.orchestra.conversation.spring.AbstractSpringOrchestraScope$1 1
org.apache.myfaces.orchestra.conversation.spring.JpaPersistenceContextFactory 1
org.apache.myfaces.orchestra.conversation.spring.OrchestraAdvisorBeanPostProcessor 3
org.apache.myfaces.orchestra.conversation.spring.PersistenceContextConversationInterceptor 1
org.apache.myfaces.orchestra.conversation.spring.ScopedBeanTargetSource 3
org.apache.myfaces.orchestra.conversation.spring.SimpleAdvisor 2
org.apache.myfaces.orchestra.lib._ReentrantLock 1
org.apache.myfaces.orchestra.lib.jsf.ExternalContextUtils 2
org.apache.myfaces.orchestra.lib.jsf.PortletOrchestraFacesContextFactory 1
org.apache.myfaces.orchestra.requestParameterProvider.RequestParameterProviderManager 3
org.apache.myfaces.orchestra.requestParameterProvider.RequestParameterResponseWrapper 2
org.apache.myfaces.orchestra.urlParamNav.UrlParameterViewHandler 2
org.apache.myfaces.orchestra.viewController.AbstractAnnotationsViewControllerManager 1
org.apache.myfaces.orchestra.viewController.jsf.ViewControllerPhaseListener 1
org.apache.myfaces.shared_orchestra.renderkit.RendererUtils 2
org.apache.myfaces.shared_orchestra.renderkit.ViewSequenceUtils 3
org.apache.myfaces.shared_orchestra.renderkit.html.HTML 44
org.apache.myfaces.shared_orchestra.renderkit.html.HtmlCheckboxRendererBase 1
org.apache.myfaces.shared_orchestra.renderkit.html.HtmlFormRendererBase 2
org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRadioRendererBase 3
org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRendererUtils 6
org.apache.myfaces.shared_orchestra.renderkit.html.HtmlResponseWriterImpl 4
org.apache.myfaces.shared_orchestra.renderkit.html.HtmlSecretRendererBase 1
org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTableRendererBase 7
org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTextRendererBase 1
org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTextareaRendererBase 1
org.apache.myfaces.shared_orchestra.renderkit.html.util.JavascriptUtils 1
org.apache.myfaces.shared_orchestra.test.ClassElementHandler 1
org.apache.myfaces.shared_orchestra.util.ExceptionUtils 1
org.apache.myfaces.shared_orchestra.util.LocaleUtils 1
org.apache.myfaces.shared_orchestra.util.MessageUtils 2
org.apache.myfaces.shared_orchestra.util.SelectItemsIterator 1
org.apache.myfaces.shared_orchestra.util.StateUtils 14
org.apache.myfaces.shared_orchestra.util.StringUtils 1
org.apache.myfaces.shared_orchestra.util.servlet.SourceCodeServlet 2
org.apache.myfaces.shared_orchestra.webapp.webxml.WebXmlParser 2

org.apache.myfaces.orchestra.conversation.ConversationManager

Bug Category Details Line
Method org.apache.myfaces.orchestra.conversation.ConversationManager.<static initializer>() invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 67
Method org.apache.myfaces.orchestra.conversation.ConversationManager.createNextConversationContextId() invokes inefficient Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 246
Method org.apache.myfaces.orchestra.conversation.ConversationManager.findConversationContextId() invokes inefficient Long(long) constructor; use Long.valueOf(long) instead PERFORMANCE DM_NUMBER_CTOR 173
Class org.apache.myfaces.orchestra.conversation.ConversationManager defines non-transient non-serializable instance field log BAD_PRACTICE SE_BAD_FIELD Not available

org.apache.myfaces.orchestra.conversation.ConversationRequestParameterProvider

Bug Category Details Line
org.apache.myfaces.orchestra.conversation.ConversationRequestParameterProvider.getFields() may expose internal representation by returning ConversationRequestParameterProvider.NO_PARAMETERS MALICIOUS_CODE EI_EXPOSE_REP 100
org.apache.myfaces.orchestra.conversation.ConversationRequestParameterProvider.getFields() may expose internal representation by returning ConversationRequestParameterProvider.REQUEST_PARAMETERS MALICIOUS_CODE EI_EXPOSE_REP 103

org.apache.myfaces.orchestra.conversation.CurrentConversationAdvice

Bug Category Details Line
org.apache.myfaces.orchestra.conversation.CurrentConversationAdvice is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID Not available

org.apache.myfaces.orchestra.conversation.CurrentConversationInfo

Bug Category Details Line
org.apache.myfaces.orchestra.conversation.CurrentConversationInfo is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID Not available

org.apache.myfaces.orchestra.conversation.jsf.AccessScopePhaseListener

Bug Category Details Line
Class org.apache.myfaces.orchestra.conversation.jsf.AccessScopePhaseListener defines non-transient non-serializable instance field log BAD_PRACTICE SE_BAD_FIELD Not available

org.apache.myfaces.orchestra.conversation.spring.AbstractSpringOrchestraScope

Bug Category Details Line
org.apache.myfaces.orchestra.conversation.spring.AbstractSpringOrchestraScope.setAdvices(Advice[]) may expose internal representation by storing an externally mutable object into AbstractSpringOrchestraScope.advices MALICIOUS_CODE EI_EXPOSE_REP2 107

org.apache.myfaces.orchestra.conversation.spring.AbstractSpringOrchestraScope$1

Bug Category Details Line
The class org.apache.myfaces.orchestra.conversation.spring.AbstractSpringOrchestraScope$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON Not available

org.apache.myfaces.orchestra.conversation.spring.JpaPersistenceContextFactory

Bug Category Details Line
JpaPersistenceContextFactory.entityManagerFactory not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.orchestra.conversation.spring.OrchestraAdvisorBeanPostProcessor

Bug Category Details Line
Should org.apache.myfaces.orchestra.conversation.spring.OrchestraAdvisorBeanPostProcessor.getAdvicesAndAdvisorsForBean(Class, String, TargetSource) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 108
Class org.apache.myfaces.orchestra.conversation.spring.OrchestraAdvisorBeanPostProcessor defines non-transient non-serializable instance field appContext BAD_PRACTICE SE_BAD_FIELD Not available
Class org.apache.myfaces.orchestra.conversation.spring.OrchestraAdvisorBeanPostProcessor defines non-transient non-serializable instance field log BAD_PRACTICE SE_BAD_FIELD Not available

org.apache.myfaces.orchestra.conversation.spring.PersistenceContextConversationInterceptor

Bug Category Details Line
PersistenceContextConversationInterceptor.persistenceContextFactory not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.orchestra.conversation.spring.ScopedBeanTargetSource

Bug Category Details Line
Class org.apache.myfaces.orchestra.conversation.spring.ScopedBeanTargetSource defines non-transient non-serializable instance field objectFactory BAD_PRACTICE SE_BAD_FIELD Not available
Class org.apache.myfaces.orchestra.conversation.spring.ScopedBeanTargetSource defines non-transient non-serializable instance field scope BAD_PRACTICE SE_BAD_FIELD Not available
org.apache.myfaces.orchestra.conversation.spring.ScopedBeanTargetSource is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID Not available

org.apache.myfaces.orchestra.conversation.spring.SimpleAdvisor

Bug Category Details Line
Class org.apache.myfaces.orchestra.conversation.spring.SimpleAdvisor defines non-transient non-serializable instance field advice BAD_PRACTICE SE_BAD_FIELD Not available
org.apache.myfaces.orchestra.conversation.spring.SimpleAdvisor is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID Not available

org.apache.myfaces.orchestra.lib._ReentrantLock

Bug Category Details Line
Class org.apache.myfaces.orchestra.lib._ReentrantLock defines non-transient non-serializable instance field log BAD_PRACTICE SE_BAD_FIELD Not available

org.apache.myfaces.orchestra.lib.jsf.ExternalContextUtils

Bug Category Details Line
Exception is caught when Exception is not thrown in org.apache.myfaces.orchestra.lib.jsf.ExternalContextUtils.getContentLength(ExternalContext) STYLE REC_CATCH_EXCEPTION 73
Exception is caught when Exception is not thrown in org.apache.myfaces.orchestra.lib.jsf.ExternalContextUtils.getRequestInputStream(ExternalContext) STYLE REC_CATCH_EXCEPTION 104

org.apache.myfaces.orchestra.lib.jsf.PortletOrchestraFacesContextFactory

Bug Category Details Line
Unread field: org.apache.myfaces.orchestra.lib.jsf.PortletOrchestraFacesContextFactory.log PERFORMANCE URF_UNREAD_FIELD 53

org.apache.myfaces.orchestra.requestParameterProvider.RequestParameterProviderManager

Bug Category Details Line
Class org.apache.myfaces.orchestra.requestParameterProvider.RequestParameterProviderManager defines non-transient non-serializable instance field LOG BAD_PRACTICE SE_BAD_FIELD Not available
org.apache.myfaces.orchestra.requestParameterProvider.RequestParameterProviderManager is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID Not available
The field org.apache.myfaces.orchestra.requestParameterProvider.RequestParameterProviderManager.providers is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Not available

org.apache.myfaces.orchestra.requestParameterProvider.RequestParameterResponseWrapper

Bug Category Details Line
VERY confusing (but perhaps intentional) to have methods org.apache.myfaces.orchestra.requestParameterProvider.RequestParameterResponseWrapper.encodeURL(String) and javax.servlet.http.HttpServletResponseWrapper.encodeUrl(String) BAD_PRACTICE NM_VERY_CONFUSING_INTENTIONAL 50-55
VERY confusing (but perhaps intentional) to have methods org.apache.myfaces.orchestra.requestParameterProvider.RequestParameterResponseWrapper.encodeUrl(String) and javax.servlet.http.HttpServletResponseWrapper.encodeURL(String) BAD_PRACTICE NM_VERY_CONFUSING_INTENTIONAL 69

org.apache.myfaces.orchestra.urlParamNav.UrlParameterViewHandler

Bug Category Details Line
Exception is caught when Exception is not thrown in org.apache.myfaces.orchestra.urlParamNav.UrlParameterViewHandler.calculateCharacterEncoding(FacesContext) STYLE REC_CATCH_EXCEPTION 106
Exception is caught when Exception is not thrown in org.apache.myfaces.orchestra.urlParamNav.UrlParameterViewHandler.initView(FacesContext) STYLE REC_CATCH_EXCEPTION 128

org.apache.myfaces.orchestra.viewController.AbstractAnnotationsViewControllerManager

Bug Category Details Line
AbstractAnnotationsViewControllerManager.annotationInfoManager not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.orchestra.viewController.jsf.ViewControllerPhaseListener

Bug Category Details Line
Class org.apache.myfaces.orchestra.viewController.jsf.ViewControllerPhaseListener defines non-transient non-serializable instance field log BAD_PRACTICE SE_BAD_FIELD Not available

org.apache.myfaces.shared_orchestra.renderkit.RendererUtils

Bug Category Details Line
Null pointer dereference of content in org.apache.myfaces.shared_orchestra.renderkit.RendererUtils.loadResourceFile(FacesContext, String) CORRECTNESS NP_ALWAYS_NULL 914
Possible null pointer dereference of content in org.apache.myfaces.shared_orchestra.renderkit.RendererUtils.loadResourceFile(FacesContext, String) CORRECTNESS NP_NULL_ON_SOME_PATH 933

org.apache.myfaces.shared_orchestra.renderkit.ViewSequenceUtils

Bug Category Details Line
Method org.apache.myfaces.shared_orchestra.renderkit.ViewSequenceUtils.getViewSequence(FacesContext) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 66
Method org.apache.myfaces.shared_orchestra.renderkit.ViewSequenceUtils.nextViewSequence(FacesContext) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 45
Method org.apache.myfaces.shared_orchestra.renderkit.ViewSequenceUtils.nextViewSequence(FacesContext) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 48

org.apache.myfaces.shared_orchestra.renderkit.html.HTML

Bug Category Details Line
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.ANCHOR_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 178
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 191
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_ONCLICK_WITHOUT_STYLE should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 199
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.ANCHOR_PASSTHROUGH_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 195
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.BUTTON_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 290
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.BUTTON_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 298
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.BUTTON_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONCLICK should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 302
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.COMMON_FIELD_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 120
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 77
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.COMMON_FIELD_EVENT_ATTRIBUTES_WITHOUT_ONFOCUS should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 85
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 147
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONCLICK should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 162
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 157
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 131
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONCLICK should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 139
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_ONCLICK_WITHOUT_STYLE should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 143
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.COMMON_PASSTROUGH_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 135
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 67
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.EVENT_HANDLER_ATTRIBUTES_WITHOUT_ONCLICK should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 55
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.FORM_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 209
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.FORM_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 218
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.IMG_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 233
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.IMG_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 246
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.INPUT_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 257
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.INPUT_FILE_UPLOAD_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 385
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 269
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.LABEL_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 313
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.MESSAGE_PASSTHROUGH_ATTRIBUTES_WITHOUT_TITLE_STYLE_AND_STYLE_CLASS should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 402
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.SELECT_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 328
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.SELECT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 334
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.SELECT_TABLE_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 409
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.TABLE_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 346
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.TABLE_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 360
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.TEXTAREA_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 369
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.TEXTAREA_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 379
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.UL_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 413
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.UNIVERSAL_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 107
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.UNIVERSAL_ATTRIBUTES_WITHOUT_STYLE should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 99
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.COMMON_FIELD_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 125
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.COMMON_FIELD_PASSTROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 152
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.INPUT_FILE_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 389
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.INPUT_PASSTHROUGH_ATTRIBUTES_WITHOUT_DISABLED_AND_ONFOCUS_AND_ONCLICK should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 274
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.LABEL_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 320
org.apache.myfaces.shared_orchestra.renderkit.html.HTML.UL_PASSTHROUGH_ATTRIBUTES should be moved out of an interface and made package protected MALICIOUS_CODE MS_OOI_PKGPROTECT 417

org.apache.myfaces.shared_orchestra.renderkit.html.HtmlCheckboxRendererBase

Bug Category Details Line
Unchecked/unconfirmed cast from javax.faces.model.SelectItem to javax.faces.model.SelectItemGroup in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlCheckboxRendererBase.renderGroupOrItemCheckbox(FacesContext, UIComponent, SelectItem, boolean, Set, Converter, boolean) STYLE BC_UNCONFIRMED_CAST 177

org.apache.myfaces.shared_orchestra.renderkit.html.HtmlFormRendererBase

Bug Category Details Line
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIForm in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlFormRendererBase.decode(FacesContext, UIComponent) STYLE BC_UNCONFIRMED_CAST 222
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIForm in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlFormRendererBase.encodeBegin(FacesContext, UIComponent) STYLE BC_UNCONFIRMED_CAST 98

org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRadioRendererBase

Bug Category Details Line
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRadioRendererBase.encodeEnd(FacesContext, UIComponent) STYLE BC_UNCONFIRMED_CAST 59
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRadioRendererBase.getConvertedValue(FacesContext, UIComponent, Object) STYLE BC_UNCONFIRMED_CAST 300
Unchecked/unconfirmed cast from javax.faces.model.SelectItem to javax.faces.model.SelectItemGroup in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRadioRendererBase.renderGroupOrItemRadio(FacesContext, UIComponent, SelectItem, Object, Converter, boolean) STYLE BC_UNCONFIRMED_CAST 165

org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRendererUtils

Bug Category Details Line
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRendererUtils.findUIOutputConverterFailSafe(FacesContext, UIComponent) STYLE BC_UNCONFIRMED_CAST 376
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectMany in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRendererUtils.findUISelectManyConverterFailsafe(FacesContext, UIComponent) STYLE BC_UNCONFIRMED_CAST 362
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectMany in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRendererUtils.getSubmittedOrSelectedValuesAsSet(boolean, UIComponent, FacesContext, Converter) STYLE BC_UNCONFIRMED_CAST 335
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UISelectOne in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRendererUtils.getSubmittedOrSelectedValuesAsSet(boolean, UIComponent, FacesContext, Converter) STYLE BC_UNCONFIRMED_CAST 342
org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRendererUtils.DEFAULT_CHAR_ENCODING isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 1344
Method call in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlRendererUtils.renderDisplayValueOnlyForSelects(FacesContext, UIComponent) passes null for unconditionally dereferenced parameter of renderSelectOptionsAsText(FacesContext, UIComponent, Converter, Set, List, boolean) CORRECTNESS NP_NULL_PARAM_DEREF 668

org.apache.myfaces.shared_orchestra.renderkit.html.HtmlResponseWriterImpl

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 117
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 189
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 263
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 359

org.apache.myfaces.shared_orchestra.renderkit.html.HtmlSecretRendererBase

Bug Category Details Line
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlSecretRendererBase.getConvertedValue(FacesContext, UIComponent, Object) STYLE BC_UNCONFIRMED_CAST 106

org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTableRendererBase

Bug Category Details Line
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTableRendererBase.encodeBegin(FacesContext, UIComponent) STYLE BC_UNCONFIRMED_CAST 108
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTableRendererBase.encodeChildren(FacesContext, UIComponent) STYLE BC_UNCONFIRMED_CAST 127
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTableRendererBase.encodeEnd(FacesContext, UIComponent) STYLE BC_UNCONFIRMED_CAST 528
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIData in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTableRendererBase.encodeInnerHtml(FacesContext, UIComponent) STYLE BC_UNCONFIRMED_CAST 209
Method org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTableRendererBase.renderColumnFooterCell(FacesContext, ResponseWriter, UIComponent, UIComponent, String, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 886
Method org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTableRendererBase.renderColumnHeaderCell(FacesContext, ResponseWriter, UIComponent, UIComponent, String, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 840
Method org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTableRendererBase.renderTableHeaderOrFooterRow(FacesContext, ResponseWriter, UIComponent, UIComponent, String, String, int) invokes inefficient Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 722

org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTextRendererBase

Bug Category Details Line
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTextRendererBase.getConvertedValue(FacesContext, UIComponent, Object) STYLE BC_UNCONFIRMED_CAST 191

org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTextareaRendererBase

Bug Category Details Line
Unchecked/unconfirmed cast from javax.faces.component.UIComponent to javax.faces.component.UIOutput in org.apache.myfaces.shared_orchestra.renderkit.html.HtmlTextareaRendererBase.getConvertedValue(FacesContext, UIComponent, Object) STYLE BC_UNCONFIRMED_CAST 92

org.apache.myfaces.shared_orchestra.renderkit.html.util.JavascriptUtils

Bug Category Details Line
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 149

org.apache.myfaces.shared_orchestra.test.ClassElementHandler

Bug Category Details Line
ClassElementHandler.buffer not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.shared_orchestra.util.ExceptionUtils

Bug Category Details Line
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_orchestra.util.ExceptionUtils.getExceptions(Throwable) STYLE REC_CATCH_EXCEPTION 59

org.apache.myfaces.shared_orchestra.util.LocaleUtils

Bug Category Details Line
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_orchestra.util.LocaleUtils.converterTagLocaleFromString(String) STYLE REC_CATCH_EXCEPTION 136

org.apache.myfaces.shared_orchestra.util.MessageUtils

Bug Category Details Line
Load of known null value in org.apache.myfaces.shared_orchestra.util.MessageUtils.getMessage(FacesContext, String, Object[]) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 373
Redundant nullcheck of message, which is known to be non-null in org.apache.myfaces.shared_orchestra.util.MessageUtils.getMessage(FacesContext, String, Object[]) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 375

org.apache.myfaces.shared_orchestra.util.SelectItemsIterator

Bug Category Details Line
SelectItemsIterator._currentUISelectItems not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available

org.apache.myfaces.shared_orchestra.util.StateUtils

Bug Category Details Line
Dead store of null to baos in org.apache.myfaces.shared_orchestra.util.StateUtils.compress(byte[]) STYLE DLS_DEAD_LOCAL_STORE_OF_NULL 217
Dead store of null to gzip in org.apache.myfaces.shared_orchestra.util.StateUtils.compress(byte[]) STYLE DLS_DEAD_LOCAL_STORE_OF_NULL 216
Dead store of null to bais in org.apache.myfaces.shared_orchestra.util.StateUtils.decompress(byte[]) STYLE DLS_DEAD_LOCAL_STORE_OF_NULL 281
Dead store of null to baos in org.apache.myfaces.shared_orchestra.util.StateUtils.decompress(byte[]) STYLE DLS_DEAD_LOCAL_STORE_OF_NULL 280
Dead store of null to gis in org.apache.myfaces.shared_orchestra.util.StateUtils.decompress(byte[]) STYLE DLS_DEAD_LOCAL_STORE_OF_NULL 282
Dead store of null to outputStream in org.apache.myfaces.shared_orchestra.util.StateUtils.getAsByteArray(Object, ExternalContext) STYLE DLS_DEAD_LOCAL_STORE_OF_NULL 189
Dead store of null to writer in org.apache.myfaces.shared_orchestra.util.StateUtils.getAsByteArray(Object, ExternalContext) STYLE DLS_DEAD_LOCAL_STORE_OF_NULL 188
Dead store of null to input in org.apache.myfaces.shared_orchestra.util.StateUtils.getAsObject(byte[], ExternalContext) STYLE DLS_DEAD_LOCAL_STORE_OF_NULL 316
Dead store of null to s in org.apache.myfaces.shared_orchestra.util.StateUtils.getAsObject(byte[], ExternalContext) STYLE DLS_DEAD_LOCAL_STORE_OF_NULL 315
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 529
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 146
Use of non-localized String.toUpperCase() or String.toLowerCase I18N DM_CONVERT_CASE 409
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_orchestra.util.StateUtils.getAsObject(byte[], ExternalContext) STYLE REC_CATCH_EXCEPTION 319
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_orchestra.util.StateUtils.symmetric(byte[], SecretKey, String, String, byte[], int) STYLE REC_CATCH_EXCEPTION 381

org.apache.myfaces.shared_orchestra.util.StringUtils

Bug Category Details Line
Should org.apache.myfaces.shared_orchestra.util.StringUtils.trim(String[]) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 685

org.apache.myfaces.shared_orchestra.util.servlet.SourceCodeServlet

Bug Category Details Line
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_orchestra.util.servlet.SourceCodeServlet.doGet(HttpServletRequest, HttpServletResponse) STYLE REC_CATCH_EXCEPTION 87
org.apache.myfaces.shared_orchestra.util.servlet.SourceCodeServlet is Serializable; consider declaring a serialVersionUID BAD_PRACTICE SE_NO_SERIALVERSIONID Not available

org.apache.myfaces.shared_orchestra.webapp.webxml.WebXmlParser

Bug Category Details Line
Exception is caught when Exception is not thrown in org.apache.myfaces.shared_orchestra.webapp.webxml.WebXmlParser.parse() STYLE REC_CATCH_EXCEPTION 112
WebXmlParser._webXml not initialized in constructor STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR Not available